Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starmon mini header changed #549

Closed
petejan opened this issue May 31, 2019 · 7 comments
Closed

starmon mini header changed #549

petejan opened this issue May 31, 2019 · 7 comments
Labels
Type:doc documentation related Type:enhancement General enhancements Unit:Instrument Reader Instrument parsers and related Unit:TimeSeries timeSeries related

Comments

@petejan
Copy link
Contributor

petejan commented May 31, 2019

StarODDI have changed the file header format to

#B	Created:	31/05/2019 11:51:00
##	Version	SeaStar	7.91
#5	Field separation:	0
#2	Date & Time:	1
#6	Decimal point:	.
#7	Date def.:	dd/mm/yyyy	/
#8	Time def.:	:
##	Axis	0	Temperature(°C)	clRed	FALSE
##	Series	0	Temp(°C)	clRed	0	Temp(°C)	2
##	Recorder	9	Starmon mini	4035
##	Chart	9T4035DAT	
#D	Data:	69802	01/08/2018 00:00:00	31/03/2019 08:45:00
1	01/08/2018 00:00:00	9.69
2	01/08/2018 00:05:00	9.65
3	01/08/2018 00:10:00	9.61
4	01/08/2018 00:15:00	9.59

The parser and Wiki needs updating to head files generated by the newer version of software

@ggalibert ggalibert added this to the 2.5.42 milestone Jun 5, 2019
@ocehugo
Copy link
Contributor

ocehugo commented Jul 19, 2019

Guys,

this should be a change in place or a new reader option? For example, older files would still require the "old" reader right?

@petejan,
may you please provide the function call signature and an example file (old and new)!?

Requirements:

  • new header reader is implemented
  • old/new reader is selectable
  • Tests for new reader is available

@ggalibert
Copy link
Contributor

I suppose any old and new formats should be supported.

@petejan
Copy link
Contributor Author

petejan commented Jul 21, 2019

Attached example files from several sensors I have,

starODDI-example.zip

@ocehugo ocehugo added Type:enhancement General enhancements Unit:Instrument Reader Instrument parsers and related labels Jul 24, 2019
@ocehugo ocehugo added Unit:TimeSeries timeSeries related Type:doc documentation related labels Aug 1, 2019
@ggalibert ggalibert modified the milestones: 2.6.1, Top of the backlog Oct 3, 2019
@ocehugo ocehugo modified the milestones: Top of the backlog, 2.6.2 Oct 4, 2019
@ocehugo ocehugo modified the milestones: 2.6.4, Top of the backlog Nov 13, 2019
@ocehugo
Copy link
Contributor

ocehugo commented Dec 4, 2019

@petejan,

For completeness, our current test file repo is missing some Staroddi example files:

a. Star-oddi with temperature corrections
b. Star-oddi with temperature in degF
c. Star-oddi with pressure corrections
d. Star-oddi with salinity data.
e. Star-oddi with pressure correction and salinity data.

any mini/dst-tilt/dst-ctd would do.

So far I have faked the above conditions based on the manual but it would be nice to have real files.

would you have any to provide to us?

Cheers

@petejan
Copy link
Contributor Author

petejan commented Dec 12, 2019

Attached data files from temperature sensors, conductivity, and pitch and roll senors,

starmon.zip

Remember the date format changes based on the users PC settings, also the data export from the starmon software needs setting up correctly.

@ocehugo
Copy link
Contributor

ocehugo commented Dec 16, 2019

Great! I already got some of those, but the salinity one is particularly useful to increase coverage. I add an issue to keep track of missing files too - #624.

@ocehugo
Copy link
Contributor

ocehugo commented Dec 18, 2019

forgot to link the old parser names to the new parser.

lbesnard added a commit that referenced this issue Dec 19, 2019
feat(Parsers): Re-use old parser names to new parser, closes #622 #549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:doc documentation related Type:enhancement General enhancements Unit:Instrument Reader Instrument parsers and related Unit:TimeSeries timeSeries related
Projects
None yet
Development

No branches or pull requests

3 participants