-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI is broken for breeze kind-cluster deploy
#16939
Comments
Yep. Very likely indeed! |
kind-cluster deploy builds prod image from sources rather than from package, so you are probably right that this change broke it! |
Hmm. But the "else" should handle it 🤔 |
Will take a look tomorrow! |
Thanks, Jarek. |
Ah yeah. due to summit, tomorrow took a bit long... But I am down to 100 messages to process. This one is on the list. |
Cool. Thanks!
|
The apache#16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes apache#16939
The #16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes #16939
…e#17086) The apache#16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes apache#16939 (cherry picked from commit 660027f)
…e#17086) The apache#16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes apache#16939
The #16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes #16939 (cherry picked from commit 660027f)
The #16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes #16939 (cherry picked from commit 660027f)
Using
breeze kind-cluster deploy
to deploy airflow in Kubernetes cluster for development results in unusable UIApache Airflow version: main
How to reproduce it:
Start kind cluster with
./breeze kind-cluster start
Deploy airflow with
./breeze kind-cluster deploy
Check the UI and see that it's broken:
Anything else we need to know:
This is likely as a result of #16577
The text was updated successfully, but these errors were encountered: