Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI is broken for breeze kind-cluster deploy #16939

Closed
ephraimbuddy opened this issue Jul 12, 2021 · 7 comments · Fixed by #17086
Closed

UI is broken for breeze kind-cluster deploy #16939

ephraimbuddy opened this issue Jul 12, 2021 · 7 comments · Fixed by #17086
Assignees
Labels
kind:bug This is a clearly a bug

Comments

@ephraimbuddy
Copy link
Contributor

Using breeze kind-cluster deploy to deploy airflow in Kubernetes cluster for development results in unusable UI

Apache Airflow version: main

How to reproduce it:
Start kind cluster with ./breeze kind-cluster start
Deploy airflow with ./breeze kind-cluster deploy

Check the UI and see that it's broken:
airflowui

Anything else we need to know:

This is likely as a result of #16577

@ephraimbuddy ephraimbuddy added the kind:bug This is a clearly a bug label Jul 12, 2021
@potiuk
Copy link
Member

potiuk commented Jul 12, 2021

Yep. Very likely indeed!

@potiuk
Copy link
Member

potiuk commented Jul 12, 2021

kind-cluster deploy builds prod image from sources rather than from package, so you are probably right that this change broke it!

@potiuk
Copy link
Member

potiuk commented Jul 12, 2021

Hmm. But the "else" should handle it 🤔

@potiuk potiuk self-assigned this Jul 12, 2021
@potiuk
Copy link
Member

potiuk commented Jul 12, 2021

Will take a look tomorrow!

@ephraimbuddy
Copy link
Contributor Author

Thanks, Jarek.
Sorry I missed your comments.
It looks to me that the image is built twice or maybe I'm not understanding what is happening...
Thanks for taking up this!

@potiuk
Copy link
Member

potiuk commented Jul 19, 2021

Ah yeah. due to summit, tomorrow took a bit long... But I am down to 100 messages to process. This one is on the list.

@ephraimbuddy
Copy link
Contributor Author

Cool. Thanks!

Ah yeah. due to summit, tomorrow took a bit long... But I am down to 100 messages to process. This one is on the list.

potiuk added a commit to potiuk/airflow that referenced this issue Jul 19, 2021
The apache#16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes apache#16939
potiuk added a commit that referenced this issue Jul 19, 2021
The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes #16939
potiuk added a commit to potiuk/airflow that referenced this issue Aug 2, 2021
…e#17086)

The apache#16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes apache#16939

(cherry picked from commit 660027f)
tzanko-matev pushed a commit to santiment/airflow that referenced this issue Aug 17, 2021
…e#17086)

The apache#16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes apache#16939
kaxil pushed a commit that referenced this issue Aug 17, 2021
The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes #16939

(cherry picked from commit 660027f)
jhtimmins pushed a commit that referenced this issue Aug 17, 2021
The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes #16939

(cherry picked from commit 660027f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants