Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes UI assets compilation from PROD image built from sources #17086

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 19, 2021

The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

  • detecting properly if the PROD image is built from sources
    (INSTALLATION_METHOD)
  • compiling the assets from sources, not from package
  • installing airflow from sources AFTER assets were compiled

Fixes #16939


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested review from ashb and kaxil as code owners July 19, 2021 16:47
@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Jul 19, 2021
The apache#16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes apache#16939
@potiuk potiuk force-pushed the fix-ui-in-source-build-prod-image branch from 9ad572b to 878525b Compare July 19, 2021 16:48
@potiuk potiuk changed the title Fix UI in source build prod image Fixes UI assets compilation from PROD image built from sources Jul 19, 2021
@potiuk potiuk requested a review from ephraimbuddy July 19, 2021 16:49
@potiuk
Copy link
Member Author

potiuk commented Jul 19, 2021

@ephraimbuddy - with this one the UI is back at the kind cluster Airflow :)

@ephraimbuddy
Copy link
Contributor

@ephraimbuddy - with this one the UI is back at the kind cluster Airflow :)

Yes. Thanks very much!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 19, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 660027f into apache:main Jul 19, 2021
@potiuk potiuk deleted the fix-ui-in-source-build-prod-image branch July 19, 2021 17:52
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 2, 2021
…e#17086)

The apache#16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes apache#16939

(cherry picked from commit 660027f)
tzanko-matev pushed a commit to santiment/airflow that referenced this pull request Aug 17, 2021
…e#17086)

The apache#16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes apache#16939
kaxil pushed a commit that referenced this pull request Aug 17, 2021
The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes #16939

(cherry picked from commit 660027f)
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.

The change fixes it by:

* detecting properly if the PROD image is built from sources
  (INSTALLATION_METHOD)
* compiling the assets from sources, not from package
* installing airflow from sources AFTER assets were compiled

Fixes #16939

(cherry picked from commit 660027f)
@potiuk potiuk restored the fix-ui-in-source-build-prod-image branch April 26, 2022 20:49
@potiuk potiuk deleted the fix-ui-in-source-build-prod-image branch July 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is broken for breeze kind-cluster deploy
2 participants