Fixes UI assets compilation from PROD image built from sources #17086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
The apache#16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes apache#16939
potiuk
force-pushed
the
fix-ui-in-source-build-prod-image
branch
from
9ad572b
to
878525b
Compare
potiuk
changed the title
|
@ephraimbuddy - with this one the UI is back at the kind cluster Airflow :) |
ephraimbuddy
approved these changes
Jul 19, 2021
Yes. Thanks very much! |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 2, 2021
…e#17086) The apache#16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes apache#16939 (cherry picked from commit 660027f)
tzanko-matev
pushed a commit
to santiment/airflow
that referenced
this pull request
Aug 17, 2021
…e#17086) The apache#16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes apache#16939
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
The #16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes #16939 (cherry picked from commit 660027f)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
The #16577 change removed yarn.lock from installed packages and it removed the possibility of preparing assets after the package is installed - so far that was the way it was done in the PROD image built from sources. The asset compilation was supposed to work after the change but it was not performed in this case. The change fixes it by: * detecting properly if the PROD image is built from sources (INSTALLATION_METHOD) * compiling the assets from sources, not from package * installing airflow from sources AFTER assets were compiled Fixes #16939 (cherry picked from commit 660027f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #16577 change removed yarn.lock from installed packages
and it removed the possibility of preparing assets after the
package is installed - so far that was the way it was done in
the PROD image built from sources. The asset compilation
was supposed to work after the change but it was not
performed in this case.
The change fixes it by:
(INSTALLATION_METHOD)
Fixes #16939
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.