Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all tests that create TaskInstances in DB also create DagRuns #17046

Closed
2 of 3 tasks
ashb opened this issue Jul 16, 2021 · 0 comments · Fixed by #17719
Closed
2 of 3 tasks

Ensure all tests that create TaskInstances in DB also create DagRuns #17046

ashb opened this issue Jul 16, 2021 · 0 comments · Fixed by #17719
Assignees
Labels
kind:task A task that needs to be completed as part of a larger issue
Milestone

Comments

@ashb
Copy link
Member

ashb commented Jul 16, 2021

As part of the work on AIP-39 we want to make it so that every TaskInstance in the DB has DagRun.

Now at "run time" this is already the case (baring the case where someone might delete a DagRun. Rare, now only possible by direct DB? I can't remember if Browse -> DagRuns allows deleting anymore or not) but in our tests this is far from the case

There are countless examples of where the tests just directly create TaskInstances, without a matching DagRun.

We need to fix that so that the tests reflect reality.

@ashb ashb added the kind:task A task that needs to be completed as part of a larger issue label Jul 16, 2021
@ashb ashb added this to the Airflow 2.2 milestone Jul 16, 2021
@ashb ashb changed the title Ensire all tests that create TaskInstances in DB also create DagRuns Ensure all tests that create TaskInstances in DB also create DagRuns Jul 26, 2021
@ashb ashb self-assigned this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant