-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add Pytest fixture to create dag and dagrun and use it on local task job tests #16889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Jul 8, 2021
ashb
reviewed
Jul 8, 2021
ashb
reviewed
Jul 8, 2021
ashb
reviewed
Jul 8, 2021
3 tasks
142bf79 to
e64c710
Compare
uranusjr
reviewed
Jul 17, 2021
uranusjr
reviewed
Jul 17, 2021
1f71c2a to
9b85232
Compare
9b85232 to
d9e9051
Compare
uranusjr
reviewed
Jul 19, 2021
d9e9051 to
901e0be
Compare
This change adds pytest fixture to to create dag and dagrun then use it on local task job tests fixup! Add fixture to create dag, task, dagrun in tests and modify /job tests fixup! fixup! Add fixture to create dag, task, dagrun in tests and modify /job tests fixup! fixup! fixup! Add fixture to create dag, task, dagrun in tests and modify /job tests fixup! fixup! fixup! fixup! Add fixture to create dag, task, dagrun in tests and modify /job tests
901e0be to
b662ac1
Compare
uranusjr
reviewed
Jul 20, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Jul 20, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:Scheduler
including HA (high availability) scheduler
full tests needed
We need to run full set of tests for this PR to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds pytest fixture to use in creating dag and dagruns
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.