Check for missing DagRun rows for "downstream" tables before migrating DB #17030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
changed the title
|
Oh, thinking about this a bit more, at least RenderedTIFields should go to TaskInstance, not DagRun |
uranusjr
approved these changes
Jul 16, 2021
3 tasks
ashb
force-pushed
the
check-missing-dagrun-before-migrate
branch
from
d6e3b85
to
c121ecb
Compare
ashb
commented
Sep 6, 2021
uranusjr
reviewed
Sep 7, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
commented
Sep 7, 2021
… migrations The migrations and code changes to switch these models over to use run_id instead of execution_date will follow in future PRs.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ashb
force-pushed
the
check-missing-dagrun-before-migrate
branch
from
fd1c601
to
6ecd6f0
Compare
…pplying migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migrations and code changes to switch these models over to use
run_id instead of execution_date will follow in future PRs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.