Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitSync optional env description #29378

Merged

Conversation

1yangsh
Copy link
Contributor

@1yangsh 1yangsh commented Feb 5, 2023

When fetching a remote git repository to a local directory,
optional command to be executed after syncing a new hash of the remote repository as occasion demands.

Added descriptions of several environmental variables for script execution.

GIT_SYNC_PERMISSION

  • Change permissions on the checked-out files to the specified mode.

GIT_SYNC_EXECHOOK_BACKOFF (default: 3s)

  • The time to wait before retrying a failed --exechook-command.

GIT_SYNC_EXECHOOK_COMMAND (script to be executed)

  • An optional command can be executed after syncing a new hash of the remote repository.

GIT_SYNC_EXECHOOK_TIMEOUT (default: 30s)

  • The timeout for the --exechook-command.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Feb 5, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 5, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@1yangsh 1yangsh force-pushed the add-chart-gitsync-env-option-description branch from d3cfc07 to df362fe Compare February 18, 2023 15:05
chart/values.yaml Outdated Show resolved Hide resolved
@1yangsh 1yangsh requested review from jedcunningham and removed request for dstandish February 22, 2023 01:45
@1yangsh 1yangsh requested review from potiuk and jedcunningham and removed request for jedcunningham and potiuk March 12, 2023 11:25
chart/values.yaml Outdated Show resolved Hide resolved
@jedcunningham jedcunningham merged commit e508e8b into apache:main Mar 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 14, 2023

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @1yangsh! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants