Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5695] use RUNNING_DEPS to check run from UI #6367

Merged
merged 1 commit into from
Oct 21, 2019
Merged

[AIRFLOW-5695] use RUNNING_DEPS to check run from UI #6367

merged 1 commit into from
Oct 21, 2019

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Oct 18, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5695
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Users are not able to run a task in the tree view page when the task state is None so users tend to Ignore all Deps, which will result in the task is run by two workers and then one of the worker will kill the airflow run itself in the heartbeat, which is less ideal. We should allow users to run tasks with RUNNABLE_STATES via UI.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@KevinYang21 @YingboWang @cong-zhu @saguziel

@KevinYang21
Copy link
Member

So what's left are:

DagrunRunningDep
DagrunIdDep
DagUnpausedDep
ExecDateAfterStartDateDep

I'm +1 for using RUNNING_DEPS when trying to trigger from webserver. Don't think the deps in the gap is what people triggering task from UI want to care. In fact from the comment I think it is meant to use RUNNING_DEPS in webserver.

@KevinYang21 KevinYang21 merged commit 3d3cc41 into apache:master Oct 21, 2019
ashb pushed a commit that referenced this pull request Dec 14, 2019
ashb pushed a commit that referenced this pull request Dec 16, 2019
kaxil pushed a commit that referenced this pull request Dec 17, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
kaxil added a commit to astronomer/airflow that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants