AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TF8 files with BOM (nitirajrathore)
|
Refer to this link for build results (access rights to CI server needed): |
rlevas
reviewed
Mar 1, 2018
|
@rlevas : No there aren't any test case to update. But surprisingly one unrelated old test case is failing. Actually let me correct that and add some test case for this as well. Thanks for comment. |
|
@rlevas : Added test cases. Please review. |
rlevas
approved these changes
Mar 1, 2018
|
Refer to this link for build results (access rights to CI server needed): |
nitirajrathore
added a commit
to nitirajrathore/ambari
that referenced
this pull request
Mar 2, 2018
…TF8 files with BOM (nitirajrathore) (apache#510) * AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) * AMBARI-22999 : Added relevant test cases (nitirajrathore)
nitirajrathore
added a commit
to nitirajrathore/ambari
that referenced
this pull request
Mar 2, 2018
…TF8 files with BOM (nitirajrathore) (apache#510) * AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) * AMBARI-22999 : Added relevant test cases (nitirajrathore)
nitirajrathore
added a commit
that referenced
this pull request
Mar 5, 2018
…TF8 files with BOM (nitirajrathore) (#510) (#527) * AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) * AMBARI-22999 : Added relevant test cases (nitirajrathore)
nitirajrathore
added a commit
that referenced
this pull request
Mar 5, 2018
…TF8 files with BOM (nitirajrathore) (#526) * AMBARI-22833 : change commons-collections-3.2.1.jar being used by ambari views to commons-collections-3.2.2.jar (nitirajrathore) * AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) (#510) * AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) * AMBARI-22999 : Added relevant test cases (nitirajrathore)
mpapirkovskyy
pushed a commit
to mpapirkovskyy/ambari
that referenced
this pull request
Apr 12, 2019
…TF8 files with BOM (nitirajrathore) (apache#510) * AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) * AMBARI-22999 : Added relevant test cases (nitirajrathore) (cherry picked from commit 541de7f) Change-Id: I58d04d819cc02fd3eb48a9e3aa96e4e22a6332bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Using BomInputStream to filterout BOM characters from the file before reading it.
How was this patch tested?
Manual testing done buy uploading the file in hive view 2.0 with BOM characters and checking if files is uploaded and given first row (which contains BOM) is treated as the list of columns for the created table.
Unit test cases added.