Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore) #526

Merged
merged 4 commits into from
Mar 5, 2018

Conversation

nitirajrathore
Copy link
Contributor

@nitirajrathore nitirajrathore commented Mar 2, 2018

What changes were proposed in this pull request?

Based on already review in branch-2.6
Using BomInputStream to filterout BOM characters from the file before reading it.

How was this patch tested?

Manual testing done buy uploading the file in hive view 2.0 with BOM characters and checking if files is uploaded and given first row (which contains BOM) is treated as the list of columns for the created table.
Unit test cases added.

…ari views to commons-collections-3.2.2.jar (nitirajrathore)
…TF8 files with BOM (nitirajrathore) (apache#510)

* AMBARI-22999 : Ambari Hive View 2.0 'Upload Table' does not support UTF8 files with BOM (nitirajrathore)

* AMBARI-22999 : Added relevant test cases (nitirajrathore)
@nitirajrathore
Copy link
Contributor Author

Sorry, I may be doing something wrong here. I just intended to merge the last commit (AMBARI-22999) in this list.
It automatically shows the first one AMBARI-22833, which I had committed before.
Also it shows the 2 merge commits in between.
Let me know if there is something I need to do here.

@asfgit
Copy link

asfgit commented Mar 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/923/
Test FAILed.
Test FAILured.

@rlevas
Copy link
Contributor

rlevas commented Mar 2, 2018

@nitirajrathore , The diff looks ok. So when we merge, we should choose Squash and Merge to squash the patches into one merge.

@rlevas
Copy link
Contributor

rlevas commented Mar 2, 2018

retest this please

@asfgit
Copy link

asfgit commented Mar 3, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/938/
Test FAILed.
Test FAILured.

@nitirajrathore
Copy link
Contributor Author

nitirajrathore commented Mar 5, 2018

This also seems to be failing in unrelated project. I am merging this as well.

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on project ambari-server: There are test failures.

@nitirajrathore nitirajrathore merged commit 123e330 into apache:trunk Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants