chore: refactored test save-paginator-status.spec.js #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for apisix-dashboard ready! Built with commit c874546 |
Codecov Report
@@ Coverage Diff @@
## master #1876 +/- ##
==========================================
+ Coverage 72.10% 72.17% +0.06%
==========================================
Files 125 125
Lines 2947 2947
Branches 711 711
==========================================
+ Hits 2125 2127 +2
+ Misses 822 820 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
juzhiyuan
approved these changes
May 9, 2021
liuxiran
reviewed
May 11, 2021
| @@ -42,57 +55,57 @@ context('Save Paginator Status', () => { | |||
| }, | |||
| body: { | |||
| upstream: { | |||
| nodes: {"39.97.63.215:80": 1}, | |||
| timeout: {connect: 6, read: 6, send: 6}, | |||
| nodes: { '39.97.63.215:80': 1 }, | |||
There was a problem hiding this comment.
it would be better to define the whole body as a test data
guoqqqi
approved these changes
May 12, 2021
LiteSun
approved these changes
May 17, 2021
liuxiran
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Refactor Testcase for Frontend.
Related issues
related issue #1774
Checklist: