Complete Extracting LogicalPlan::Drop* DDL related plan structures into LogicalPlan::Ddl #6144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
changed the title
alamb
force-pushed
the
alamb/complete_ddl
branch
from
fa48254 to
8325565
Compare
This was referenced Apr 27, 2023
alamb
commented
Apr 27, 2023
| LogicalPlan::DropTable(DropTable { | ||
| name, if_exists, .. | ||
| }) => { | ||
| let result = self.find_and_deregister(&name, TableType::Base).await; |
Contributor
Author
There was a problem hiding this comment.
I moved these into their own functions for consistency
metesynnada
reviewed
Apr 28, 2023
Contributor
metesynnada
left a comment
metesynnada
left a comment
There was a problem hiding this comment.
LGTM, this will significantly streamline the logical plans. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
LogicalPlan::Drop*DDL related plan structures intoLogicalPlan::DdlWhich issue does this PR close?
Closes #1281
Rationale for this change
While reviewing #6096 from @jaylmiller I noticed that the LogicalPlan was getting quite large for the various Catalog manipulation statements
What changes are included in this PR?
Move
LogicalPlan::Drop*variants intoLogicalPlan::Ddlto keep them more isolatedAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
Yes, this is an API change -- some LogicalPlan variants are now wrapped up another layer of struct