Minor: consolidate test data #6217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
May 3, 2023
| #[tokio::test] | ||
| async fn sort_with_lots_of_repetition_values() -> Result<()> { | ||
| let ctx = SessionContext::new(); | ||
| let filename = "tests/parquet/data/repeat_much.snappy.parquet"; |
Contributor
Author
There was a problem hiding this comment.
the parquet one was particularly confusing because tests/parquet also has a bunch of rust code as well
Contributor
Author
|
unless anyone objects I plan to merge this in later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While looking through https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests I noticed there were some directories that had some random data in them. I think consolidating into a shared single location will make the codebase easier to work with
What changes are included in this PR?
Move test data into a single location, and update tests with new locations
Are these changes tested?
yes
Are there any user-facing changes?
no