Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] S3FileSystem equals None causes bus error #38535

Closed
matthewdeng opened this issue Nov 1, 2023 · 1 comment · Fixed by #39276
Closed

[Python] S3FileSystem equals None causes bus error #38535

matthewdeng opened this issue Nov 1, 2023 · 1 comment · Fixed by #39276
Assignees
@AlenkaF
Labels
Component: Python Type: bug
Milestone
15.0.0

Comments

@matthewdeng
Copy link

Describe the bug, including details regarding any error messages, version, and platform.

Version: pyarrow==13.0.0

Repro script:

import pyarrow.fs

fs = pyarrow.fs.S3FileSystem()
fs != None

Output:

[1]    77091 bus error  python

I can do fs is not None as a workaround for now.

Component(s)

Python
@matthewdeng matthewdeng mentioned this issue Nov 1, 2023
Merged
8 tasks
@jorisvandenbossche jorisvandenbossche changed the title S3FileSystem equals None causes bus error [Python] S3FileSystem equals None causes bus error Dec 13, 2023
@jorisvandenbossche jorisvandenbossche added this to the 15.0.0 milestone Dec 13, 2023
@jorisvandenbossche
Copy link
Member

@matthewdeng Thanks for the report! Can confirm this also happens on the main branch.

I think there is a not None missing in the signature here:

arrow/python/pyarrow/_fs.pyx

Line 508 in 4aa9f60

def equals(self, FileSystem other):

@github-actions github-actions bot mentioned this issue Dec 18, 2023
Merged
jorisvandenbossche pushed a commit that referenced this issue Dec 19, 2023
@AlenkaF
GH-38535: [Python] Fix S3FileSystem equals None segfault (#39276)
f5dd3d4 
### Rationale for this change

`S3FileSystem` equals `None` currently causes bus error.

### What changes are included in this PR?

Add `not None` to `FileSystem.equals` signature.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38535

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@AlenkaF @clayburn
apacheGH-38535: [Python] Fix S3FileSystem equals None segfault (apach…
b1af17c 
…e#39276)

### Rationale for this change

`S3FileSystem` equals `None` currently causes bus error.

### What changes are included in this PR?

Add `not None` to `FileSystem.equals` signature.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38535

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@AlenkaF @dgreiss
apacheGH-38535: [Python] Fix S3FileSystem equals None segfault (apach…
bf30196 
…e#39276)

### Rationale for this change

`S3FileSystem` equals `None` currently causes bus error.

### What changes are included in this PR?

Add `not None` to `FileSystem.equals` signature.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38535

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Python Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38535: [Python] Fix S3FileSystem equals None segfault AlenkaF/arrow
3 participants
@jorisvandenbossche @matthewdeng @AlenkaF