Skip to content

Conversation

jorgecarleitao
Copy link
Member

@jorgecarleitao jorgecarleitao commented May 20, 2021

These are two minor fixes to the release script.

  1. Made git not fetch the 15k tags on crossbow and instead. This was causing timeouts
  2. pass the ARTIFACTORY_API_KEY to the docker image so that it can use it in pushing artifacts

@jorgecarleitao jorgecarleitao requested review from kou and kszucs and removed request for kou May 20, 2021 13:24
: ${CROSSBOW_JOB_ID:="${crossbow_job_prefix}-${CROSSBOW_JOB_NUMBER}"}

archery crossbow download-artifacts ${CROSSBOW_JOB_ID}
archery crossbow download-artifacts ${CROSSBOW_JOB_ID} --no-fetch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only works if the job from submitted from the same machine - which should be true in most of the cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can revisit this when this causes a problem.

For example, we can use CROSSBOW_ARGS environment variable to customize this behavior:

: ${CROSSBOW_ARGS:=--no-fetch}

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou pitrou requested review from kou and kszucs July 27, 2021 08:11
@kou kou changed the title [Release] Fixes to release script ARROW-13468: [Release] Fix binary download/upload failures Jul 27, 2021
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants