ARROW-8241: [Rust] Add Schema convenience methods index_of and field_with_name #6740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paddyhoran @nevi-me PTAL if you have time. |
paddyhoran
approved these changes
Mar 27, 2020
rust/arrow/src/datatypes.rs
Outdated
| @@ -1221,6 +1221,26 @@ impl Schema { | |||
| &self.fields[i] | |||
| } | |||
|
|
|||
| /// Returns an immutable reference of a specific `Field` instance selected by name | |||
| pub fn field_with_name(&self, name: &str) -> Result<&Field> { | |||
| for i in 0..self.fields.len() { | |||
There was a problem hiding this comment.
Why not use index_of inside field_with_name?
There was a problem hiding this comment.
Thanks @paddyhoran I implemented that suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Schema convenience methods
index_ofandfield_with_namefor a better developer experience.I also fixed some duplicate code in the tests.