ARROW-11971: [Packaging] Vcpkg patch doesn't apply on windows due to line endings #9713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
commented
Mar 15, 2021
|
|
||
| # Used for the manylinux and windows wheels | ||
| VCPKG=c7e96f2a5b73b3278b004aa88abec2f8ebfb43b5 | ||
| VCPKG=fced4bef1606260f110d74de1ae1975c2b9ac549 |
There was a problem hiding this comment.
Had to bump vcpkg's version, otherwise I'm getting consistent download errors for mingw on windows.
There was a problem hiding this comment.
This hash points to the latest commit on vcpkg's main branch.
|
@github-actions crossbow submit -g wheel |
1 similar comment
|
@github-actions crossbow submit -g wheel |
|
Revision: 27c4393 Submitted crossbow builds: ursacomputing/crossbow @ actions-227
|
|
CI error is unrelated, merging. |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…line endings Closes apache#9713 from kszucs/vcpkg-patch Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…line endings Closes apache#9713 from kszucs/vcpkg-patch Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.