Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0 #12877

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

kennknowles
Copy link
Member


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kennknowles
Copy link
Member Author

Still running linkage checker, will paste results here.

@kennknowles
Copy link
Member Author

run java postcommit

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #12877 into master will decrease coverage by 0.02%.
The diff coverage is 69.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12877      +/-   ##
==========================================
- Coverage   82.35%   82.32%   -0.03%     
==========================================
  Files         450      452       +2     
  Lines       53708    53985     +277     
==========================================
+ Hits        44230    44444     +214     
- Misses       9478     9541      +63     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/snowflake.py 64.15% <ø> (ø)
...eam/runners/portability/fn_api_runner/fn_runner.py 89.74% <ø> (ø)
...apache_beam/runners/portability/portable_runner.py 77.37% <ø> (ø)
...beam/testing/benchmarks/nexmark/queries/query10.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/transforms/stats.py 87.39% <20.00%> (-3.03%) ⬇️
...on/apache_beam/runners/direct/sdf_direct_runner.py 36.06% <50.00%> (ø)
...pache_beam/runners/interactive/interactive_beam.py 76.02% <64.40%> (-10.53%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 92.16% <66.66%> (+0.01%) ⬆️
sdks/python/apache_beam/dataframe/frames.py 90.02% <83.33%> (-0.47%) ⬇️
...ache_beam/runners/dataflow/ptransform_overrides.py 90.00% <85.71%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e6c72...7fec038. Read the comment docs.

@kennknowles
Copy link
Member Author

Ran ./gradlew -Ppublishing -PjavaLinkageArtifactIds=beam-sdks-java-io-google-cloud-platform,beam-runners-google-cloud-dataflow-java :checkJavaLinkage > ~/tmp/linkage-after against master and this PR. Both fail, but here is the diff, with no additional errors:

13094,13096c13115,13117
<     com.google.cloud.hadoop.gcsio.cooplock.CoopLockOperationDao (com.google.cloud.bigdataoss:gcsio:2.1.3)
<     com.google.cloud.hadoop.gcsio.cooplock.CoopLockRecordsDao (com.google.cloud.bigdataoss:gcsio:2.1.3)
<     com.google.cloud.hadoop.gcsio.testing.InMemoryObjectEntry (com.google.cloud.bigdataoss:gcsio:2.1.3)
---
>     com.google.cloud.hadoop.gcsio.cooplock.CoopLockOperationDao (com.google.cloud.bigdataoss:gcsio:2.1.5)
>     com.google.cloud.hadoop.gcsio.cooplock.CoopLockRecordsDao (com.google.cloud.bigdataoss:gcsio:2.1.5)
>     com.google.cloud.hadoop.gcsio.testing.InMemoryObjectEntry (com.google.cloud.bigdataoss:gcsio:2.1.5)
13100c13121
<       unselected: org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.25.0-SNAPSHOT (compile) / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.25.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.1.3 (compile) / com.google.guava:guava:29.0-jre (compile)
---
>       unselected: org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.25.0-SNAPSHOT (compile) / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.25.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.1.5 (compile) / com.google.guava:guava:29.0-jre (compile)
13122c13143
<   and 696 other dependency paths.
---
>   and 714 other dependency paths.
13153,13154c13174,13175
< com.google.cloud.bigdataoss:gcsio:2.1.3 is at:
<   org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.25.0-SNAPSHOT (compile) / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.25.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.1.3 (compile)
---
> com.google.cloud.bigdataoss:gcsio:2.1.5 is at:
>   org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.25.0-SNAPSHOT (compile) / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.25.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.1.5 (compile)
13163c13184

@lukecwik
Copy link
Member

Run Python_PVR_Flink PreCommit

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the linkage checker and it confirms that there are no new linkage errors.

@lukecwik
Copy link
Member

What was the error that you were seeing that required you to run it manually?

@kennknowles
Copy link
Member Author

I may have done it manually when I did not have to. I followed https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades. I just decided to run gradle directly for no particular reason.

@kennknowles
Copy link
Member Author

I see that the script does more than I realized. I will use it next time.

@kennknowles kennknowles merged commit 8f0da17 into apache:master Sep 22, 2020
@kennknowles kennknowles deleted the gcsio-upgrade branch September 22, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants