[BEAM-2021] Remove Coder Encoding IDs #2717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgroh
force-pushed
the
remove_encoding_ids
branch
from
ee9005f
to
412a9b7
Compare
|
R: @kennknowles |
|
LGTM. So much bikeshedding deleted with this 😣 😁 😂 |
tgroh
force-pushed
the
remove_encoding_ids
branch
from
412a9b7
to
9b876ec
Compare
These were never safe to use, and will not be used once Coders have been migrated to the Runner API representation.
tgroh
force-pushed
the
remove_encoding_ids
branch
from
9b876ec
to
8c6a31d
Compare
4 tasks
|
retest this please |
|
run dataflow validatesrunner |
|
run dataflow validatesrunner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
These were never safe to use, and will not be used once Coders have been
migrated to the Runner API representation.