[BEAM-2021] Rename StandardCoder to StructuredCoder#2720
Merged
asfgit merged 1 commit intoapache:masterfrom Apr 29, 2017
Merged
[BEAM-2021] Rename StandardCoder to StructuredCoder#2720asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Member
|
Rebase & test. Probably want to check the ValidatesRunner suites somewhat just to be sure. |
tgroh
force-pushed
the
structured_coder_not_standard_coder
branch
2 times, most recently
from
84b4835 to
44ee6d8
Compare
Member
Author
|
run dataflow validatesrunner |
tgroh
force-pushed
the
structured_coder_not_standard_coder
branch
from
44ee6d8 to
92c9a87
Compare
tgroh
force-pushed
the
structured_coder_not_standard_coder
branch
from
92c9a87 to
0378e8f
Compare
Member
Author
|
run dataflow validatesrunner |
kennknowles
reviewed
Apr 29, 2017
|
|
||
| <properties> | ||
| <dataflow.container_version>beam-master-20170421</dataflow.container_version> | ||
| <dataflow.container_version>beam-master-20170428</dataflow.container_version> |
Member
There was a problem hiding this comment.
You don't need this any more; we are on a worker beyond it.
kennknowles
approved these changes
Apr 29, 2017
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
LGTM. This is a very helpful rename.
StandardCoder has improper connotations - mainly, "Standard" as in "Standardized" as opposed to "Standard" as in "normal". StructuredCoder communicates the important part of the class, which is that the coder has some meaningful structure, and that structure can be used by a runner. Update Dataflow Worker Version
tgroh
force-pushed
the
structured_coder_not_standard_coder
branch
from
0378e8f to
2d13bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
StandardCoder has improper connotations - mainly, "Standard" as in
"Standardized" as opposed to "Standard" as in "normal". StructuredCoder
communicates the important part of the class, which is that the coder
has some meaningful structure, and that structure can be used by a
runner.
Keep StandardCoder around as a temporary shim for the DataflowRunner.
Will be removed as soon as an updated worker is available.
To be merged after #2717
R: @kennknowles or @lukecwik