[BEAM-5634] Bring dataflow java worker code into beam #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyuanzz
changed the title
boyuanzz
changed the title
|
Run Java PostCommit |
herohde
approved these changes
Oct 4, 2018
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
boyuanzz
force-pushed
the
dataflow_java_worker
branch
3 times, most recently
from
be28f55
to
30296ce
Compare
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
boyuanzz
force-pushed
the
dataflow_java_worker
branch
from
6416b5b
to
a29f4aa
Compare
boyuanzz
force-pushed
the
dataflow_java_worker
branch
from
2390713
to
daccd09
Compare
|
This PR is ready for merge. @kennknowles |
|
Thanks! Once IP clearance is complete, I will (squash &) merge it. |
|
IP clearance is good; going to re-run Java presubmit since it has been a few days. |
|
run java precommit |
|
All tests passed. This PR is ready to merge. Thanks for your help! @kennknowles |
robertwb
reviewed
Oct 9, 2018
| } | ||
| } | ||
|
|
||
| compile "org.apache.beam:beam-model-fn-execution:$version" |
There was a problem hiding this comment.
Won't this pull the dependency from maven rather than try and build what's in this repository? (I could be missunderstanding things, but it seems we want compile project(...) here instead.)
There was a problem hiding this comment.
Thanks @robertwb. I think you are right. I'll create a new PR to fix this build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit ad135ab simply copied all dataflow java worker code into runners/google-cloud-dataflow-java/worker: r: @herohde @kennknowles
commit fc89e6a fixed spotless errors.
commit 5dca67a migrated worker build into project root: r: @markflyhigh @herohde