Enable CLI completion for integration, kit, kamelet names

[tadayosi]

Currently there's no completion after for example:

kamel get/delete [TAB]
kamel kit get/delete [TAB]
kamel kamelet delete [TAB]
kamel bind [TAB]

Ideally they should show the integration/kit/kamelet names already deployed on the cluster.

[squakez]

Do you think is this okey for "good first issue" label?

[github-actions]

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

[gansheer]

The kamel kit delete completion already exists : the command only shows non-platform kits. Is this behavior something that should evolve to all kits (even the platform ones) for the kamel kit delete or should it stay like this?
I don't know why this exclusion of platform kits is done.

camel-k/pkg/cmd/completion_bash.go

Lines 160 to 170 in 322e43c

	__kamel_kubectl_get_non_platform_integrationkits() {
	local template
	local kubectl_out
	template="{{ range .items }}{{ .metadata.name }} {{ end }}"
	label_condition="camel.apache.org/kit.type!=platform"
	if kubectl_out=$(kubectl get -l ${label_condition} -o template --template="${template}" integrationkits 2>/dev/null); then
	COMPREPLY=( $( compgen -W "${kubectl_out}" -- "$cur" ) )
	fi
	}

@lburgazzoli @astefanutti do you have any information ?

[gansheer]

@tadayosi @squakez

What is expected on then kamel bind autocomplete ? While we could default to the custom resources kamelets.camel.apache.org, the command description "Bind Kubernetes resources, such as Kamelets, in an integration flow. Endpoints are expected in the format "[[apigroup/]version:]kind:[namespace/]name" or plain Camel URIs." clearly indicates more possibilities.

What I understand from "Kubernetes resources" looks like a lot of possible kubernetes objects (more than we could predict) to have an autocomplete on it but I might be wrong.

[squakez]

What is expected on then kamel bind autocomplete ?

The kamel bind can accept any kamelet or generic Camel URI. I'd say that the autocompletion could look up on Kamelets that are available in the namespace where we're willing to run the KameletBinding. We cannot do much more than that, as the user can provide any other URI.

[tadayosi]

Yeah, as @gansheer outlined it doesn't seem to make much sense to provide auto completion for kamel bind as it accepts a variety of inputs. We can focus on the other commands for implementing auto completion and ignore kamel bind for the time being.

[astefanutti]

The kamel kit delete completion already exists : the command only shows non-platform kits. Is this behavior something that should evolve to all kits (even the platform ones) for the kamel kit delete or should it stay like this? I don't know why this exclusion of platform kits is done.

camel-k/pkg/cmd/completion_bash.go

Lines 160 to 170 in 322e43c

	__kamel_kubectl_get_non_platform_integrationkits() {
	local template
	local kubectl_out
	template="{{ range .items }}{{ .metadata.name }} {{ end }}"
	label_condition="camel.apache.org/kit.type!=platform"
	if kubectl_out=$(kubectl get -l ${label_condition} -o template --template="${template}" integrationkits 2>/dev/null); then
	COMPREPLY=( $( compgen -W "${kubectl_out}" -- "$cur" ) )
	fi
	}

@lburgazzoli @astefanutti do you have any information ?

I think the general idea was that kits of type platform are managed by the operator, as opposed to kits created by users, and should be "hidden" away from users.

[gansheer]

I think the general idea was that kits of type platform are managed by the operator, as opposed to kits created by users, and should be "hidden" away from users.

I get the idea, but since the command allows the deletion platform kits without any specific flag I wonder if it is a good idea to have a completion that does not retrieve the same results than the allowed values for the command.

I fear it might just confuse the user. I am really tempted to remove the platform exclusion filter but am unsure about the end user real life use case.

[tadayosi]

Hi,

I get the idea, but since the command allows the deletion platform kits without any specific flag I wonder if it is a good idea to have a completion that does not retrieve the same results than the allowed values for the command.

Actually, no, you cannot delete platform kits with kamel kit delete. They are protected from cli. There's even no flag to force performing it. So sometimes I tend to need to do this to clean up platform kits: kubectl delete ik ...

[gansheer]

Hi,

Hi,

Actually, no, you cannot delete platform kits with kamel kit delete. They are protected from cli. There's even no flag to force performing it. So sometimes I tend to need to do this to clean up platform kits: kubectl delete ik ...

You are absolutely right, I just realized I used the kubectl command most of the time. The completion command is good for kamel kit delete.

Thank you 👍