Sort the integration configurations before returning #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Nov 24, 2020
lburgazzoli
approved these changes
Nov 24, 2020
astefanutti
approved these changes
Nov 24, 2020
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1824
The list of
spec.configurationsin theIntegrationends up as volumes and volumeMounts in the Knative service. The ordering of these is determined by this package: https://github.com/scylladb/go-setThere is no ordering implied here, which is perfectly fine, except that Knative sees the order of the volumes and volume mounts as a change worthy of a new revision. When there are many configmaps and secrets in the integration, the number of additional revisions is quite large (50-60, sometimes more) and a new pod is generated for each one. Sorting the list before returning it ensures the ordering is consistent, and Knative will only generate a single revision.
Release Note