Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more information when the build fails #2307

Closed
wants to merge 1 commit into from

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented May 18, 2021

Fix GH issue #2306

Release Note

Integration build error absent on the operator logs

@orpiske
Copy link
Contributor Author

orpiske commented May 18, 2021

With this patch, then it logs:

{"level":"error","ts":1621322905.2870088,"logger":"camel-k","msg":"Unable to complete build: could not pull base image image localhost:5000/openjdk11:slim: Get \"https://localhost:5000/v2/\": dial tcp 127.0.0.1:
5000: connect: connection refused","stacktrace":"github.com/apache/camel-k/pkg/util/log.Errorf\n\tgithub.com/apache/camel-k/pkg/util/log/log.go:201\ngithub.com/apache/camel-k/pkg/controller/build.(*scheduleRouti
neAction).runBuild\n\tgithub.com/apache/camel-k/pkg/controller/build/schedule_routine.go:162"}

@orpiske orpiske added the kind/bug Something isn't working label May 18, 2021
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fixed with cd18611 that's part of #2269.

If you prefer to have your fix in earlier, could you please double check it's taken into account into the above?

pkg/controller/build/schedule_routine.go Outdated Show resolved Hide resolved
@orpiske
Copy link
Contributor Author

orpiske commented May 18, 2021

I think it's fixed with cd18611 that's part of #2269.

If you prefer to have your fix in earlier, could you please double check it's taken into account into the above?

I think this one can wait for #2269 (unless that one is not going on 1.5). I think it can wait for it to be merged and then I can add this on top of that since it's a much smaller patch. IMHO, we can close this for now.

@astefanutti
Copy link
Member

I think it's fixed with cd18611 that's part of #2269.
If you prefer to have your fix in earlier, could you please double check it's taken into account into the above?

I think this one can wait for #2269 (unless that one is not going on 1.5). I think it can wait for it to be merged and then I can add this on top of that since it's a much smaller patch. IMHO, we can close this for now.

Sounds good. Yes #2269 will be part of 1.5.

@orpiske
Copy link
Contributor Author

orpiske commented May 18, 2021

@astefanutti awesome, thanks! Let's close this one.

@orpiske orpiske closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants