Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): operator additional info #2730

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Nov 5, 2021

With this PR we enhance the kamel version command to allow retrieve more information such as:

$ ./kamel version -av -n operator-test
Camel K Client 1.7.0-SNAPSHOT
Git Commit: 2629b4e7b8e91d40d006474f73f9b5cf6be377cb

Camel K Operator 1.7.0-SNAPSHOT
Runtime Version: 1.10.0-SNAPSHOT
Git Commit: fcf6dbaa7b5bb565e433fb390b3dccb2ec9aa900
Go OS: linux
Go Version: go1.17
Publish Strategy: Spectrum
  • Added some useful information into IntegrationPlatform
  • It can be later retrieved by kamel version --operator -v command
  • Enhanced the command to include --all showing both client and operator info
  • Added unit test

Closes #1947

Release Note

feat(cmd): operator additional info

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds a bit odd to me, because I know that an integration platform can only be associated with only one operator at any point in time, but I think this is the first case where we put operator information on the platform.

I don't see a better option btw, this looks clean.

* Added some useful information into IntegrationPlatform
* It can be later retrieved by `kamel version --operator -v` command
* Enhanced the command to include `--all` showing both client and operator info
* Added unit test

Closes apache#1947
@squakez
Copy link
Contributor Author

squakez commented Nov 10, 2021

Failing because some E2E flaky test as reported in #2744. Merging it if there is no objection.

@squakez squakez merged commit 0ddccc6 into apache:main Nov 11, 2021
@squakez squakez deleted the feat/1947_operator_info branch November 11, 2021 08:41
@oscerd oscerd mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose operator information
4 participants