chore(knative): do not change spec during processing #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 3, 2019
lburgazzoli
reviewed
Jan 3, 2019
| "github.com/mitchellh/mapstructure" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "strings" |
There was a problem hiding this comment.
I think this is going to hurt golintci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles state changes completely in the status field in order to avoid changing the spec fields during processing. Changing spec should be avoided because in case the Integration is owned by a upper-level controller, the reconciliation process of the other controller is triggered resulting in conflicts.