-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for openapi/swagger #328
Conversation
pkg/trait/knative.go
Outdated
@@ -133,7 +133,7 @@ func (t *knativeTrait) getServiceFor(e *Environment) *serving.Service { | |||
}) | |||
|
|||
sources := make([]string, 0, len(e.Integration.Spec.Sources)) | |||
for i, s := range e.Integration.Spec.Sources { | |||
for i, s := range e.Integration.Sources() { | |||
envName := fmt.Sprintf("CAMEL_K_ROUTE_%03d", i) | |||
envvar.SetVal(&environment, envName, s.Content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can s.content
be missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, I will fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolaferraro should be fixed now
9cfe851
to
29b9431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Should you open a ticket for adding support for e.g. caching? |
yes we need also to do some magic to configure routes/ingress & so on. will raise some new issues later on |
Initial support for OpenAPI v2
Fixes #323