Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#3399): Improve operator log level adjustments #3401

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix(#3399): Improve operator log level adjustments #3401

merged 1 commit into from
Jul 5, 2022

Conversation

christophd
Copy link
Contributor

  • Use zap log level enabler implementation to set global log level
  • Use Camel K logger wrapper in operator
  • Use Debug wrapper methods
  • Add some documentation of LOG_LEVEL envvar and its setting via kamel CLI

@christophd
Copy link
Contributor Author

@phantomjinx not sure if this fixes the whole issue yet some improvements on the operator log level adjustments

phantomjinx
phantomjinx approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/cmd/operator/operator.go Show resolved Hide resolved
@christophd christophd force-pushed the issue/3399/operator-log-level branch 2 times, most recently from f64f24b to 2f61ade Compare July 1, 2022 14:44
@christophd
fix(apache#3399): Improve operator log level adjustments
2ef6198 
- Use zap log level enabler implementation to set global log level
- Use Camel K logger wrapper in operator
- Use Debug wrapper methods
- Add some documentation of LOG_LEVEL envvar and its setting via kamel CLI
@christophd christophd force-pushed the issue/3399/operator-log-level branch from 2f61ade to 2ef6198 Compare July 1, 2022 14:56
@squakez squakez merged commit 079c1f0 into apache:main Jul 5, 2022
@squakez squakez mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@phantomjinx phantomjinx phantomjinx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophd @phantomjinx @squakez