Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(e2e): reuse namespaces as much as possible for E2E tests #3451

Merged
merged 9 commits into from
Jul 16, 2022
Merged

chore(e2e): reuse namespaces as much as possible for E2E tests #3451

merged 9 commits into from
Jul 16, 2022

Conversation

tadayosi
Copy link
Member

This applies our e2e policy to reuse namespaces as much as possible on the E2E tests, discussed at #3298:

Have a single TestRun() function and define multiple t.Run("xxx", ...) blocks inside WithNewTestNamespace(), which uses only a single namespace and platform throughout the test suite.

as well as some refactoring too.

Fix #3298

Release Note

NONE

phantomjinx
phantomjinx suggested changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things but otherwise looks good.

e2e/global/builder/registry_test.go Show resolved Hide resolved
e2e/namespace/install/cli/run_test.go Outdated Show resolved Hide resolved
@tadayosi tadayosi merged commit 19eea8d into apache:main Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantomjinx phantomjinx phantomjinx requested changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
area/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our preference on defining multiple e2e tests
3 participants
@tadayosi @phantomjinx @oscerd