Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix invalid type mapping for operator resources and securityContext #3516

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

zhiminglim
Copy link
Contributor

This PR fixes the errors thrown when performing a helm install <chart-name> . --dry-run due to invalid mapping types.

Example error log:

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.containers[0].securityContext): invalid type for io.k8s.api.core.v1.SecurityContext: got "string", expected "map"

The errors are fixed by adding helm flow control. Additionally, the blocks after {{- with .. }} only executes if the values are not empty.

@zhiminglim
Copy link
Contributor Author

@oscerd thanks for approving! I'm not sure who to tag, but it seems a maintainer has to approve running workflows as I'm a first-time contributor.

@squakez
Copy link
Contributor

squakez commented Aug 9, 2022

@oscerd thanks for approving! I'm not sure who to tag, but it seems a maintainer has to approve running workflows as I'm a first-time contributor.

Checks started :)

@squakez squakez merged commit d4eadad into apache:main Aug 11, 2022
@zhiminglim zhiminglim deleted the fix/helm-operator-values branch August 11, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants