Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the default maven repositories if extra ones are added #3684

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Adds the default maven repositories if extra ones are added #3684

merged 1 commit into from
Oct 4, 2022

Conversation

phantomjinx
Copy link
Contributor

Avoids the default maven repositories being removed from the maven settings by the new specified repositories

Release Note


When overriding the maven repository settings, the default repositories should still be retained to avoid losing the base
dependencies.

@oscerd
Copy link
Contributor

oscerd commented Sep 28, 2022

This should be in 1.10.x too I guess.

@phantomjinx
Copy link
Contributor Author

This should be in 1.10.x too I guess.

#3687

tadayosi
tadayosi approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to mention ENTESB in a commit log for upstream Camel projects. Otherwise all look good.

@phantomjinx phantomjinx changed the title ENTESB-19670: Adds the default maven repositories if extra ones are added Adds the default maven repositories if extra ones are added Sep 29, 2022
@phantomjinx
Adds the default maven repositories if extra ones are added
79689d2 
* Avoids the default maven repositories being removed from the maven
  settings by the new specified repositories
@phantomjinx
Copy link
Contributor Author

I'd prefer not to mention ENTESB in a commit log for upstream Camel projects. Otherwise all look good.

No worries. Repushed commits in this and backport PRs.

@tadayosi tadayosi added the kind/bug Something isn't working label Sep 30, 2022
@tadayosi tadayosi added this to the 1.11.0 milestone Sep 30, 2022
@tadayosi tadayosi merged commit 11aaa93 into apache:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phantomjinx @oscerd @tadayosi