Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): Add validation to trait enum parameters in CRDs #3696

Merged
merged 2 commits into from
Oct 3, 2022
Merged

chore(api): Add validation to trait enum parameters in CRDs #3696

merged 2 commits into from
Oct 3, 2022

Conversation

astefanutti
Copy link
Member

This follows up #1614, by adding validation for possible enumeration values.

Release Note

chore(api): Add validation to trait enum parameters in CRDs

tadayosi
tadayosi approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@tadayosi tadayosi added the kind/feature New feature or request label Sep 29, 2022
@tadayosi tadayosi added this to the 1.11.0 milestone Sep 29, 2022
@astefanutti astefanutti merged commit 4a12ebc into apache:main Oct 3, 2022
@astefanutti astefanutti deleted the pr-433 branch October 3, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@astefanutti @tadayosi @oscerd