Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move native into nigtly release wf #3860

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Nov 30, 2022

With this PR we execute the native smoke test during the nighlty release execution. In this way we enable it on main branch but also on the rest of supported release branches and we're forced to look into them as they block the nightly release.

Release Note

chore(ci): move native into nigtly release wf 

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw, the reason why we spun off the native IT was because it alone takes 2+ hours to run. By combining it with the nightly WF, now it would take extra 2+ hours to release and may grow further in the future. If it's something we can accept then I think it's good to go.

@tadayosi
Copy link
Member

tadayosi commented Dec 1, 2022

Ah, now it seems improved and it only takes around 40 mins when successful:
https://github.com/apache/camel-k/actions/runs/3588127371
Possibly it's because of mandrel native build image upgrade and improvement of native compilation from Quarkus.

@squakez
Copy link
Contributor Author

squakez commented Dec 1, 2022

Ah, now it seems improved and it only takes around 40 mins when successful: https://github.com/apache/camel-k/actions/runs/3588127371 Possibly it's because of mandrel native build image upgrade and improvement of native compilation from Quarkus.

Yeah, more than that I have the feeling that the resources it uses to take at night are exclusively dedicated as there is no other PR or task running in parallel. In general we should be fine if the whole combination of checks spans during all the night, there is no real pressure on having the night cycle short.

@squakez squakez merged commit ff41193 into apache:main Dec 1, 2022
@squakez squakez deleted the chore/native_releases branch December 1, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants