-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): isolate kustomize tests not to interfere with each other #3863
fix(e2e): isolate kustomize tests not to interfere with each other #3863
Conversation
Hmm, while I still believe the fix is a good to have, unfortunately it doesn't seem to solve the original issue completely. I'll look into it further... |
5f8fbe7
to
1bce55b
Compare
@squakez @phantomjinx I've been doing several things on this pull req, and it seems I finally reached the point where the kustomize tests are actually stabilised. I've experimented and applied several improvements here, but among those the most contributing change is apparently this: 1bce55b |
Yes, I've noticed in the past that we have mixed scripts with |
1bce55b
to
995cb6b
Compare
What I see as the possible root cause of the random kustomize tests failures is that
kustomize
taintskustomization.yaml
underinstall/
each test run and it could be that the installation scripts are not idempotent, so the random order of test executions sometimes cause misconfigurations.This fix copies
install/
every time to/tmp
and run the tests there to ensure independence of kustomize tests.Fix #3772 #3861
Release Note