Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): isolate kustomize tests not to interfere with each other #3863

Merged
merged 10 commits into from
Dec 13, 2022

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Dec 1, 2022

What I see as the possible root cause of the random kustomize tests failures is that kustomize taints kustomization.yaml under install/ each test run and it could be that the installation scripts are not idempotent, so the random order of test executions sometimes cause misconfigurations.

This fix copies install/ every time to /tmp and run the tests there to ensure independence of kustomize tests.

Fix #3772 #3861

Release Note

NONE

@tadayosi
Copy link
Member Author

tadayosi commented Dec 1, 2022

Hmm, while I still believe the fix is a good to have, unfortunately it doesn't seem to solve the original issue completely.
https://github.com/tadayosi/camel-k/actions/runs/3589400137/jobs/6041791903

I'll look into it further...

@tadayosi tadayosi marked this pull request as draft December 7, 2022 04:43
@tadayosi tadayosi force-pushed the Issue-3772-fix-kustomize-tests branch from 5f8fbe7 to 1bce55b Compare December 12, 2022 06:52
@tadayosi tadayosi marked this pull request as ready for review December 12, 2022 06:52
@tadayosi
Copy link
Member Author

tadayosi commented Dec 12, 2022

@squakez @phantomjinx I've been doing several things on this pull req, and it seems I finally reached the point where the kustomize tests are actually stabilised.

I've experimented and applied several improvements here, but among those the most contributing change is apparently this: 1bce55b
So surprisingly, what is causing the Kustomize E2E instability seems to be the mixed use of bash and dash in Makefile!

@squakez
Copy link
Contributor

squakez commented Dec 12, 2022

@squakez @phantomjinx I've been doing several things on this pull req, and it seems I finally reached the point where the kustomize tests are actually stabilised.

I've experimented and applied several improvements here, but among those the most contributing change is apparently this: 1bce55b So surprisingly, what is causing the Kustomize E2E instability seems to be the mixed use of bash and dash in Makefile!

Yes, I've noticed in the past that we have mixed scripts with bash or sh. I guess that at some point we should harmonize them as well.

@tadayosi tadayosi force-pushed the Issue-3772-fix-kustomize-tests branch from 1bce55b to 995cb6b Compare December 13, 2022 04:23
@tadayosi tadayosi merged commit 77eb66b into apache:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E - Kustomize tests are unstable
2 participants