feature(kamel): Validate --context when given #423
Conversation
rhuss
force-pushed
the
pr/camel-k-validation-fix
branch
2 times, most recently
from
b75931c
to
a2c8b27
Compare
| it.in.headers['RandomValue'] = rnd.nextInt() | ||
| } | ||
| .to('log:info?showHeaders=true') | ||
| name: routes.groovy |
There was a problem hiding this comment.
May this be changed by the fact that your pr is created from an old commit ?
There was a problem hiding this comment.
Not sure. I added a sorting option to ls when creating that file previously, but it seems that the PR has not been taken over. Actually it then depends on the way how ls works on different systems how resources are picked up. My ls uses alphabetical sort order by default, so orders 'cr-example.yml' after 'camel-catalog-2.23.1.yaml' and before 'crd-camel-catalog.yaml'.
In this file frommaster 'cr-example.yml' comes right before 'operator-deployment-kubernetes.yml' which seems wrong if you assume alphabetical ordering.
I'd recommend to add a "| sort |" after ls to not depend on platform default for "ls"'s ordering.
There was a problem hiding this comment.
It's here where I would add a | sort in between.
There was a problem hiding this comment.
not sure what appended but I see this commit
https://github.com/apache/camel-k/commit/c2053bfe2155bb1e418457840434d8b07bde6985
There was a problem hiding this comment.
Sorry, there is already a sort at the end.
So no idea how this file was regenerated the last time.
There was a problem hiding this comment.
so looks like there are some differences between linux and osx implementations
There was a problem hiding this comment.
I don't think so as this final | sort works the same on linux and osx. No idea though why the resource list checked in in master is not sorted.
I suggest to merge this in (as its sorted now), and check for a PR which changes this again into a non-sorted order.
rhuss
force-pushed
the
pr/camel-k-validation-fix
branch
2 times, most recently
from
5c020e5
to
cadad01
Compare
|
Test failure is unrelated to this change: |
|
working on it |
rhuss
force-pushed
the
pr/camel-k-validation-fix
branch
from
cadad01
to
6f58b7b
Compare
|
Updated with extra check. |
No description provided.