-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e) Upgrade test operators #4309
Conversation
pkg/util/defaults/defaults.go
Outdated
@@ -26,7 +26,7 @@ const ( | |||
Version = "2.0.0-SNAPSHOT" | |||
|
|||
// DefaultRuntimeVersion -- | |||
DefaultRuntimeVersion = "3.20.1-SNAPSHOT" | |||
DefaultRuntimeVersion = "2.16.0-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be already changed in main
branch. Probably rebasing would sort the same effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main
branch is still on 3.20.1. Maybe there is a problem in a script ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, probably. There should be a nightly action that is in charge to regenerate this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed by #4313. You can however remove this change, because when you make build
it will take care to refresh on its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the commit 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I've merged the aforementioned PR, at next automatic nightly update, it will refresh everything.
15cdb1e
to
f925b71
Compare
f925b71
to
d598d00
Compare
Upgrade e2e deployed operators:
Update defaults for DefaultRuntimeVersion
Release Note