Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Probes to Knative services #514

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Adding Probes to Knative services #514

merged 1 commit into from
Mar 5, 2019

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Mar 1, 2019 •
edited
Loading

This requires runtime >= 3.1.0-SNAPSHOT

To quickly set it up at installation timer

kamel install --runtime-version=3.1.0-SNAPSHOT --snapshot-repositories

Fixes #511

@lburgazzoli lburgazzoli changed the title Adding Probes to Knative services #511 Adding Probes to Knative services Mar 1, 2019
@lburgazzoli lburgazzoli marked this pull request as ready for review March 1, 2019 13:32
nicolaferraro
nicolaferraro approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we may want to add other options to customize timing and failure behavior. I'll add a new issue for this.

@nicolaferraro nicolaferraro merged commit 660a190 into apache:master Mar 5, 2019
@lburgazzoli lburgazzoli deleted the github-511-probes branch March 5, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lburgazzoli @nicolaferraro