Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affinity trait #607

Merged
merged 4 commits into from
Apr 12, 2019
Merged

Add affinity trait #607

merged 4 commits into from
Apr 12, 2019

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Apr 11, 2019

Fixes #601.

@davsclaus
Copy link
Contributor

I wonder if we should have a doc page with all those traits, and a bit of details what each of them do

@astefanutti
Copy link
Member Author

astefanutti commented Apr 12, 2019

I wonder if we should have a doc page with all those traits, and a bit of details what each of them do

We have https://github.com/apache/camel-k/blob/master/docs/traits.adoc#common-traits. I'm currently updating it for that new affinity trait, but as I'm documenting it, I keep finding new ways to improve it 😄 (Documentation driven development!)

@astefanutti
Copy link
Member Author

Added documentation in fe3bbd7.

@lburgazzoli
Copy link
Contributor

@astefanutti is it ready ? or writing docs triggered other things you want to include ? :)

@astefanutti
Copy link
Member Author

@lburgazzoli I think this is ready 😃!

@lburgazzoli lburgazzoli merged commit 1fd3404 into apache:master Apr 12, 2019
@astefanutti astefanutti deleted the pr-28 branch April 12, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add options to configure affinity
3 participants