Skip to content

Commit c53aad5

Browse files
author
Michael Penick
committed
Code review fixes
1 parent bd8e4d5 commit c53aad5

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/token_map.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,8 @@ TokenMap* TokenMap::from_partitioner(StringRef partitioner) {
2525
return new TokenMapImpl<Murmur3Partitioner>();
2626
} else if (ends_with(partitioner, RandomPartitioner::name())) {
2727
return new TokenMapImpl<RandomPartitioner>();
28-
return NULL;
2928
} else if (ends_with(partitioner, ByteOrderedPartitioner::name())) {
3029
return new TokenMapImpl<ByteOrderedPartitioner>();
31-
return NULL;
3230
} else {
3331
LOG_WARN("Unsupported partitioner class '%s'", partitioner.to_string().c_str());
3432
return NULL;

src/token_map_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ struct ReplicationFactor {
172172
size_t count;
173173
std::string name; // Used for logging the datacenter name
174174
bool operator==(const ReplicationFactor& other) const {
175-
return count == other.count;
175+
return count == other.count && name == other.name;
176176
}
177177
};
178178

0 commit comments

Comments
 (0)