Skip to content

Commit 2aeedc8

Browse files
committed
add missed out [#expect(deprecated)] assertions
1 parent 100e9b7 commit 2aeedc8

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

datafusion/expr/src/udaf.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,12 @@ impl AggregateUDF {
208208
self.inner.window_function_display_name(params)
209209
}
210210

211+
#[deprecated(
212+
since = "52.0.0",
213+
note = "Use `return_field` instead with return_field.is_nullable()."
214+
)]
211215
pub fn is_nullable(&self) -> bool {
212-
#[allow(deprecated)]
216+
#[expect(deprecated)]
213217
self.inner.is_nullable()
214218
}
215219

@@ -534,7 +538,7 @@ pub trait AggregateUDFImpl: Debug + DynEq + DynHash + Send + Sync {
534538
/// but others like `MIN` will return `NULL` if there is nullable input.
535539
/// Note that if the function is declared as *not* nullable, make sure the [`AggregateUDFImpl::default_value`] is `non-null`
536540
#[deprecated(
537-
since = "51.0.0",
541+
since = "52.0.0",
538542
note = "Use `return_field` instead with return_field.is_nullable()."
539543
)]
540544
fn is_nullable(&self) -> bool {
@@ -1105,7 +1109,7 @@ pub fn udaf_default_return_field<F: AggregateUDFImpl + ?Sized>(
11051109
Ok(Arc::new(Field::new(
11061110
func.name(),
11071111
data_type,
1108-
#[allow(deprecated)]
1112+
#[expect(deprecated)]
11091113
{
11101114
func.is_nullable()
11111115
},
@@ -1255,7 +1259,7 @@ impl AggregateUDFImpl for AliasedAggregateUDFImpl {
12551259
}
12561260

12571261
fn is_nullable(&self) -> bool {
1258-
#[allow(deprecated)]
1262+
#[expect(deprecated)]
12591263
self.inner.is_nullable()
12601264
}
12611265

datafusion/ffi/src/udaf/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ impl From<Arc<AggregateUDF>> for FFI_AggregateUDF {
344344
fn from(udaf: Arc<AggregateUDF>) -> Self {
345345
let name = udaf.name().into();
346346
let aliases = udaf.aliases().iter().map(|a| a.to_owned().into()).collect();
347+
#[expect(deprecated)]
347348
let is_nullable = udaf.is_nullable();
348349
let volatility = udaf.signature().volatility.into();
349350

0 commit comments

Comments
 (0)