You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: Add WITH ORDER display in information_schema.views (#18282)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes#123` indicates that this PR will close issue #123.
-->
- Closes#18267.
/cc @NGA-TRAN
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
The `information_schema.views` does not have display `WITH ORDER` for
the definition of a table.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
Added condition for writing `WITH ORDER` for CreateExternalTable.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Did not add tests for this functionality as not other display
functionality has tests and seems like a separate PR would be
appropriate if this is needed.
This was tested manually with:
In `datafusion-cli`
```
-- Not sorted
CREATE EXTERNAL TABLE dimension_csv
STORED AS CSV
LOCATION '/path/to/the/attached/dimension_1.csv'
OPTIONS ('format.has_header' 'true');
-- Sorted
CREATE EXTERNAL TABLE dimension_csv_sorted
STORED AS CSV
WITH ORDER (env, service, host)
LOCATION '/path/to/the/attached/dimension_1.csv'
OPTIONS ('format.has_header' 'true');
```
Then running:
```
select * from information_schema.views;
```
With link to data:
[dimension_1.csv](https://github.com/user-attachments/files/23124138/dimension_1.csv)
## Are there any user-facing changes?
Yes, improves the information_schema.views display to include `WITH
ORDER`
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
datafusion public abc_multi_order CREATE EXTERNAL TABLE abc_multi_order STORED AS CSV WITH ORDER (c1, c2 DESC) LOCATION ../../testing/data/csv/aggregate_test_100.csv
datafusion public abc_order_nulls CREATE EXTERNAL TABLE abc_order_nulls STORED AS CSV WITH ORDER (c1 NULLS LAST, c2 DESC NULLS FIRST) LOCATION ../../testing/data/csv/aggregate_test_100.csv
752
+
753
+
statement ok
754
+
DROP TABLE abc_order_nulls;
755
+
708
756
# string_agg has different arg_types but same return type. Test avoiding duplicate entries for the same function.
709
757
query TTT
710
758
select routine_name, data_type, function_type from information_schema.routines where routine_name = 'string_agg';
0 commit comments