Remove Expr::GetIndexedField, replace Expr::{field,index,range} with FieldAccessor, IndexAccessor, and SliceAccessor
#10568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
sql
logical-expr
jayzhan211
commented
May 18, 2024
| @@ -233,3 +241,120 @@ impl TableSource for MyTableSource { | |||
| self.schema.clone() | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_nested_schema_nullability() { | |||
There was a problem hiding this comment.
Move tests that use functions to core/tests
jayzhan211
commented
May 18, 2024
| @@ -1037,29 +1037,6 @@ mod tests { | |||
| assert_optimized_plan_equal(plan, expected) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_struct_field_push_down() -> Result<()> { | |||
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
alamb
reviewed
May 20, 2024
| @@ -61,7 +63,7 @@ fn test_eq_with_coercion() { | |||
| #[test] | |||
| fn test_get_field() { | |||
| evaluate_expr_test( | |||
| get_field(col("props"), "a"), | |||
| col("props").field("a"), | |||
alamb
changed the title
Expr::GetIndexedField and fix panic of field, index and rangeExpr::GetIndexedField, replace Expr::{field,index,range} with FieldAccessor, IndexAccessor, and SliceAccessor
alamb
approved these changes
May 20, 2024
There was a problem hiding this comment.
This is great -- thank you @jayzhan211 . I had one small comment regarding the placement of docstrings but I also think we could do that as a follow on PR
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! Extension methods for Expr. |
There was a problem hiding this comment.
This is a very clever idea. Thank you @jayzhan211
| } | ||
|
|
||
| impl IndexAccessor for Expr { | ||
| /// Return access to the element field. Example `expr["name"]` |
There was a problem hiding this comment.
I think the way that rustdoc works, this documentation won't appear on index -- can you please move the docs and example to IndexAccessor itself?
| } | ||
|
|
||
| impl FieldAccessor for Expr { | ||
| /// Return access to the named field. Example `expr["name"]` |
There was a problem hiding this comment.
likewise here I think we need to move the docs / example to FieldAccessor rather than on the impl in Expr
| @@ -287,24 +284,6 @@ pub fn create_physical_expr( | |||
| input_dfschema, | |||
| execution_props, | |||
| )?), | |||
| Expr::GetIndexedField(GetIndexedField { expr: _, field }) => match field { | |||
|
Thanks, @alamb ! |
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
May 21, 2024
…ith `FieldAccessor`, `IndexAccessor`, and `SliceAccessor` (apache#10568) * remove expr Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add expr extension Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * doc Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * move test that has struct Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fmt Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add foc and fix displayed name Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * rm test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * rebase Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * move doc Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10374.
Closes #10565
Rationale for this change
What changes are included in this PR?
After the change, you need to import
to use old expression api.
Are these changes tested?
Are there any user-facing changes?