FLINK-2523: Makes the task cancellation interval configurable. #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. |
kl0u
force-pushed
the
cancelation_interval
branch
3 times, most recently
from
66f27d7 to
52aa8e3
Compare
|
Just rebased. Please review this PR. |
|
Thanks for your contribution @kl0u. Changes for the task cancellation interval look good. Maybe it would be good to add a test case which makes sure that the |
…es it to the Task itself. FLINK-3327: Attaches the ExecutionConfig to the JobGraph and propagates it to the Task itself.
kl0u
force-pushed
the
cancelation_interval
branch
from
52aa8e3 to
45d64c5
Compare
|
@tillrohrmann @aljoscha @StephanEwen I just rebased on the current master. This PR is rebased on top of #1583. Please review. |
|
will merge this today. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Mar 14, 2016
|
Thank you. The changes in b75fd3f look good! |
|
Thanks a lot! I will rebase in a bit! |
|
You don't need to rebase. Chesnay did that already. |
subhankarb
pushed a commit
to subhankarb/flink
that referenced
this pull request
Mar 17, 2016
fijolekProjects
pushed a commit
to fijolekProjects/flink
that referenced
this pull request
May 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is rebased on top of #1583 . Please review that first.