FLINK-3327: ExecutionConfig to JobGraph. #1583

kl0u · 2016-02-03T18:39:00Z

This makes the ExecutionConfig available to the Task. In a nutshell, the ExecutionConfig is attached to the JobGraph which is sent to the JobManager. The JobManager passes it to the ExecutionGraph, and, later on, to the TaskDeploymentDescriptor, and the TaskManager puts it into the Environment, which is visible to the AbstractInvocable.

StephanEwen · 2016-02-09T15:11:21Z

Looks good at a first glance. I'll try to go through it and see if I can merge it...

kl0u · 2016-02-09T15:37:05Z

Thanks a lot @StephanEwen

kl0u · 2016-02-10T15:07:58Z

Please review the new pull request.
This pull request is the first step for the one about FLINK-2523.

Thanks a lot!

kl0u · 2016-02-15T14:48:33Z

Hello! Just rebased to the new master. Please review.

zentol · 2016-02-15T15:19:31Z

flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java

 			return 1;
 		}
-
+		


only change made in this file is formatting.

zentol · 2016-02-15T15:24:53Z

we could probably heavily reduce the diff by providing JobGraph constructors with/without the executionconfig argument. (if none is given, we just instantiate a new one)

zentol · 2016-02-15T15:26:48Z

flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java

 	public int getNumberOfExecutionRetries() {
-		return numExecutionRetries;
+		int retries = executionConfig.getNumberOfExecutionRetries();
+		if (retries < -1) {


this check shouldn't be necessary, since setNumberOfExecutionRetries already checks for it.

zentol · 2016-02-15T15:42:51Z

Made a few remarks, but didn't find any issue that isn't a minor one. Good job!

kl0u · 2016-02-18T10:08:07Z

Please Review.

zentol · 2016-02-18T10:21:53Z

Changes look good. Do you know what happened to the ExecutionStateProgressTest diff?

kl0u · 2016-02-18T13:58:36Z

The problem is the CRLF vs LF characters in the committed versions of the files.

kl0u · 2016-02-18T17:44:16Z

Please Review this PR.

kl0u · 2016-02-22T12:00:43Z

Just rebased. Please review this PR.

…es it to the Task itself.

kl0u · 2016-03-07T16:28:48Z

@StephanEwen , @zentol I just rebased to the latest master.
It passes all tests on my Travis (https://travis-ci.org/kl0u/flink/builds/114228524).

Please review because the PR touches a lot of classes.

zentol · 2016-03-07T16:41:23Z

looks like something went wrong while rebasing, a commit by aljoscha suddenly popped up.

but hey, that can be fixed while merging, +1 from me.

kl0u · 2016-03-07T16:43:17Z

Thanks a lot @zentol

zentol · 2016-03-10T20:30:28Z

are there any objections to merging this? let's get this one in.

zentol · 2016-03-11T20:36:23Z

merging this.

kl0u · 2016-03-11T23:48:41Z

Thanks a lot!

This closes apache#1583

kl0u force-pushed the config_to_jobgraph branch 6 times, most recently from 7fe608d to fdf74f0 Compare February 9, 2016 09:56

kl0u force-pushed the config_to_jobgraph branch 4 times, most recently from 3fd32bb to f2594da Compare February 9, 2016 23:37

kl0u changed the title ~~ExecutionConfig to JobGraph.~~ FLINK-3327: ExecutionConfig to JobGraph. Feb 10, 2016

kl0u force-pushed the config_to_jobgraph branch 2 times, most recently from 3105029 to 84299ba Compare February 10, 2016 14:48

kl0u force-pushed the config_to_jobgraph branch from 84299ba to aa6ca2b Compare February 15, 2016 13:14

zentol reviewed Feb 15, 2016
View reviewed changes

kl0u force-pushed the config_to_jobgraph branch 3 times, most recently from 6b89c89 to df3a84f Compare February 17, 2016 15:35

kl0u force-pushed the config_to_jobgraph branch 2 times, most recently from 948e978 to 2495fea Compare February 17, 2016 16:16

kl0u mentioned this pull request Feb 17, 2016

FLINK-2523: Makes the task cancellation interval configurable. #1662

Closed

kl0u force-pushed the config_to_jobgraph branch 2 times, most recently from 7c690c5 to de135e2 Compare February 18, 2016 13:44

kl0u force-pushed the config_to_jobgraph branch 2 times, most recently from 519432b to ea35baa Compare February 22, 2016 11:03

kl0u force-pushed the config_to_jobgraph branch 2 times, most recently from 8f7d9fa to 7ced60c Compare March 5, 2016 14:34

[hotfix] Fix typos in Trigger.java

9d3d709

kl0u force-pushed the config_to_jobgraph branch from 7ced60c to 8722e3f Compare March 7, 2016 09:42

FLINK-3327: Attaches the ExecutionConfig to the JobGraph and propagat…

59bcbfe

…es it to the Task itself.

kl0u force-pushed the config_to_jobgraph branch from 8722e3f to 59bcbfe Compare March 7, 2016 12:34

StephanEwen mentioned this pull request Mar 8, 2016

[FLINK-3583] User configuration visible in webdashboard when job is running #1768

Closed

asfgit closed this in 0f8d76c Mar 11, 2016

subhankarb pushed a commit to subhankarb/flink that referenced this pull request Mar 17, 2016

[FLINK-3327] ExecutionConfig to JobGraph

c5df832

This closes apache#1583

kl0u deleted the config_to_jobgraph branch June 9, 2016 13:26

rmetzger added the component=Runtime/Coordination label Mar 14, 2019

FLINK-3327: ExecutionConfig to JobGraph. #1583

FLINK-3327: ExecutionConfig to JobGraph. #1583

Uh oh!

Conversation

kl0u commented Feb 3, 2016

Uh oh!

StephanEwen commented Feb 9, 2016

Uh oh!

kl0u commented Feb 9, 2016

Uh oh!

kl0u commented Feb 10, 2016

Uh oh!

kl0u commented Feb 15, 2016

Uh oh!

zentol Feb 15, 2016

Choose a reason for hiding this comment

Uh oh!

zentol commented Feb 15, 2016

Uh oh!

zentol Feb 15, 2016

Choose a reason for hiding this comment

Uh oh!

zentol commented Feb 15, 2016

Uh oh!

kl0u commented Feb 18, 2016

Uh oh!

zentol commented Feb 18, 2016

Uh oh!

kl0u commented Feb 18, 2016

Uh oh!

kl0u commented Feb 18, 2016

Uh oh!

kl0u commented Feb 22, 2016

Uh oh!

kl0u commented Mar 7, 2016

Uh oh!

zentol commented Mar 7, 2016

Uh oh!

kl0u commented Mar 7, 2016

Uh oh!

zentol commented Mar 10, 2016

Uh oh!

zentol commented Mar 11, 2016

Uh oh!

kl0u commented Mar 11, 2016

Uh oh!

Uh oh!