Skip to content

[FLINK-3583] User configuration visible in webdashboard when job is running #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FLINK-3583] User configuration visible in webdashboard when job is running #1768

wants to merge 1 commit into from

Conversation

fijolekProjects
Copy link
Contributor

Before:
no-configuration-when-job-running

After;
after-changes

aljoscha
aljoscha reviewed Mar 8, 2016
View reviewed changes
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java Outdated
this.timeout = timeout;

this.restartStrategy = restartStrategy;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephanEwen @uce was there a reason for not reading the executionConfig at this point already?

@aljoscha
Copy link
Contributor

aljoscha commented Mar 8, 2016

Thanks for your PR! I'll look into whether loading the ExecutionConfig earlier breaks anything and then merge it.

@StephanEwen
Copy link
Contributor

I think that #1583 also addresses parts this, in a more generic fashion.
Reading the config earlier should not be a problem.

I would vote to get first #1583 and then from this pull request only the web frontend changes.

@aljoscha
Copy link
Contributor

aljoscha commented Mar 8, 2016

Ok, makes sense.

@fijolekProjects
Copy link
Contributor Author

Thanks, I removed backend changes

@aljoscha
Copy link
Contributor

Hi @fijolekProjects,
could you please confirm that everything works now that #1583 is merged. If yes, then I would like to merge this one as well.

@fijolekProjects
Copy link
Contributor Author

Hi @aljoscha I can confirm that after merging #1583 this change looks good

@aljoscha
Copy link
Contributor

Thanks a lot! I merged it.

Could you please close this PR if github does not do so automatically.

@fijolekProjects
Copy link
Contributor Author

Thanks @aljoscha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=Runtime/WebFrontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fijolekProjects @aljoscha @StephanEwen @rmetzger