[FLINK-29095][state] Improve logging in SharedStateRegistry #20722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredia could you take a look please? |
|
@flinkbot run azure |
fredia
reviewed
Sep 27, 2022
| LOG.trace( | ||
| "Updating last checkpoint for {} from {} to {}", | ||
| "Duplicated registration under key {} with a placeholder (normal case)", | ||
| registrationKey); |
There was a problem hiding this comment.
Maybe lack of scheduledStateDeletion = newHandle;?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve logging in
SharedStateRegistryand make the conditional logic more clear.
Verifying this change
This change is a trivial rework without any (new) test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation