Skip to content

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Oct 24, 2022

What is the purpose of the change

Improve logging in SharedStateRegistry
and make the conditional logic more clear.
This PR is copied from #20722 and address comment.

Verifying this change

This change is a trivial rework without any (new) test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 24, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredia thanks for the update, left some minor comments, please let me know what do you think about them, thanks.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredia thanks for the update, LGTM. will merge if there is not more comments from the community in the new days.

@klion26
Copy link
Member

klion26 commented Nov 8, 2022

@fredia thanks for the contribution, merging it now.

@klion26 klion26 merged commit 9a4250d into apache:master Nov 8, 2022
@fredia fredia deleted the pr20722 branch March 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants