[FLINK-32863][runtime-web] Improve Flink UI's time precision from sec… #23403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarmaGYZ
reviewed
Sep 13, 2023
Comment on lines
58
to
65
| return `${hours}h ${minutes}m ${seconds}s ${ms}ms`; | ||
| } | ||
| } | ||
| } else { | ||
| if (short) { | ||
| return `${days}d ${hours}h`; | ||
| } else { | ||
| return `${days}d ${hours}h ${minutes}m ${seconds}s`; | ||
| return `${days}d ${hours}h ${minutes}m ${seconds}s ${ms}ms`; |
There was a problem hiding this comment.
nit: I think the explicit ms might be useless for jobs longer than 1h.
There was a problem hiding this comment.
Thanks for your suggestion, it has been fixed.
hejufang
force-pushed
the
support_millisecond
branch
from
4f3ce28 to
eb76869
Compare
masteryhx
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Thanks for the contribution.
Do we also need to adjust the precision of checkpoint related time ?
I have seen some cases that checkpoint completes within 1s then the Checkpoint UI will show same value about start time and end time.
cc @KarmaGYZ
|
@masteryhx +1 for also adjusting checkpoint precision. |
hejufang
force-pushed
the
support_millisecond
branch
from
eb76869 to
da68a22
Compare
|
@masteryhx Thank you for your suggestion. I have adjusted the precision of checkpoint related time. please review. cc @KarmaGYZ |
…ond level to millisecond level
hejufang
force-pushed
the
support_millisecond
branch
from
da68a22 to
de9db2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve Flink UI's time precision from second level to millisecond level.
Brief change log
Improve Flink UI's time precision from second level to millisecond level, includes job duration, task duration, task start time, end time.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation