Skip to content

[FLINK-32863][runtime-web] Improve Flink UI's time precision from sec… #23403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[FLINK-32863][runtime-web] Improve Flink UI's time precision from sec… #23403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flink-runtime-web/web-dashboard/src/app/components/humanize-duration.pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ export class HumanizeDurationPipe implements PipeTransform {
if (seconds === 0) {
return `${ms}ms`;
} else {
return `${seconds}s`;
return `${seconds}s ${ms}ms`;
}
} else {
return `${minutes}m ${seconds}s`;
return `${minutes}m ${seconds}s ${ms}ms`;
}
} else {
if (short) {
Expand Down
4 changes: 2 additions & 2 deletions flink-runtime-web/web-dashboard/src/app/components/job-list/job-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
class="clickable"
>
<td>{{ job.name }}</td>
<td>{{ job['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ job['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ job.duration | humanizeDuration }}</td>
<td>{{ job['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ job['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>
<flink-task-badge [tasks]="job.tasks"></flink-task-badge>
</td>
Expand Down
2 changes: 1 addition & 1 deletion ...-web/web-dashboard/src/app/pages/job-manager/log-list/job-manager-log-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
{{ narrowData.name }}
</a>
</td>
<td>{{ narrowData.mtime | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ narrowData.mtime | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ narrowData.size / 1024 | number: '1.0-2' }}</td>
</tr>
</ng-container>
Expand Down
2 changes: 1 addition & 1 deletion .../web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<td *ngIf="checkPointDetail['tasks'][vertex.id]['latest_ack_timestamp'] >= 0">
{{
checkPointDetail['tasks'][vertex.id]['latest_ack_timestamp']
| date: 'yyyy-MM-dd HH:mm:ss'
| date: 'yyyy-MM-dd HH:mm:ss.SSS'
}}
</td>
<td *ngIf="checkPointDetail['tasks'][vertex.id]['latest_ack_timestamp'] < 0">n/a</td>
Expand Down
12 changes: 6 additions & 6 deletions flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
<strong>Completion Time:</strong>
{{
checkPointStats['latest']['completed']['latest_ack_timestamp']
| date: 'yyyy-MM-dd HH:mm:ss'
| date: 'yyyy-MM-dd HH:mm:ss.SSS'
}}
</span>
<nz-divider nzType="vertical"></nz-divider>
Expand Down Expand Up @@ -115,7 +115,7 @@
<strong>Failure Time:</strong>
{{
checkPointStats['latest']['failed']['failure_timestamp']
| date: 'yyyy-MM-dd HH:mm:ss'
| date: 'yyyy-MM-dd HH:mm:ss.SSS'
}}
</span>
<nz-divider nzType="vertical"></nz-divider>
Expand Down Expand Up @@ -151,7 +151,7 @@
<strong>Completion Time:</strong>
{{
checkPointStats['latest']['savepoint']['latest_ack_timestamp']
| date: 'yyyy-MM-dd HH:mm:ss'
| date: 'yyyy-MM-dd HH:mm:ss.SSS'
}}
</span>
<nz-divider nzType="vertical"></nz-divider>
Expand Down Expand Up @@ -196,7 +196,7 @@
<strong>Restore Time:</strong>
{{
checkPointStats['latest']['restored']['restore_timestamp']
| date: 'yyyy-MM-dd HH:mm:ss'
| date: 'yyyy-MM-dd HH:mm:ss.SSS'
}}
</span>
<nz-divider nzType="vertical"></nz-divider>
Expand Down Expand Up @@ -275,9 +275,9 @@
}})
</span>
</td>
<td>{{ checkpoint['trigger_timestamp'] | date: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ checkpoint['trigger_timestamp'] | date: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td *ngIf="checkpoint['latest_ack_timestamp'] >= 0">
{{ checkpoint['latest_ack_timestamp'] | date: 'yyyy-MM-dd HH:mm:ss' }}
{{ checkpoint['latest_ack_timestamp'] | date: 'yyyy-MM-dd HH:mm:ss.SSS' }}
</td>
<td *ngIf="checkpoint['latest_ack_timestamp'] < 0">n/a</td>
<td *ngIf="checkpoint['end_to_end_duration'] >= 0">
Expand Down
2 changes: 1 addition & 1 deletion ...eb-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
<tr *ngFor="let subTask of table.data">
<td>{{ subTask['index'] }}</td>
<ng-container *ngIf="subTask['status'] === 'completed'">
<td>{{ subTask['ack_timestamp'] | date: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ subTask['ack_timestamp'] | date: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>
{{ subTask['end_to_end_duration'] | humanizeDuration }}
<span *ngIf="subTask['aborted']">(aborted)</span>
Expand Down
4 changes: 2 additions & 2 deletions ...k-runtime-web/web-dashboard/src/app/pages/job/job-detail/status/job-status.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@
</ng-template>
</nz-descriptions-item>
<nz-descriptions-item nzTitle="Start Time">
{{ jobDetail['start-time'] | date: 'yyyy-MM-dd HH:mm:ss' }}
{{ jobDetail['start-time'] | date: 'yyyy-MM-dd HH:mm:ss.SSS' }}
</nz-descriptions-item>
<nz-descriptions-item nzTitle="End Time" *ngIf="jobDetail['end-time'] > -1">
{{ jobDetail['end-time'] | date: 'yyyy-MM-dd HH:mm:ss' }}
{{ jobDetail['end-time'] | date: 'yyyy-MM-dd HH:mm:ss.SSS' }}
</nz-descriptions-item>
<nz-descriptions-item nzTitle="Duration">
{{ jobDetail.duration | humanizeDuration }}
Expand Down
4 changes: 2 additions & 2 deletions ...web-dashboard/src/app/pages/job/overview/detail/job-overview-drawer-detail.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@
</dt>
<dd>Start Time</dd>
<dt>
{{ node.detail['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}
{{ node.detail['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}
</dt>
<dd>End Time</dd>
<dt>
{{ node.detail['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}
{{ node.detail['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}
</dt>
<dd>Duration</dd>
<dt>
Expand Down
4 changes: 2 additions & 2 deletions ...untime-web/web-dashboard/src/app/pages/job/overview/list/job-overview-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
</b>
</span>
</td>
<td>{{ node.detail['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ node.detail['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ node.detail?.duration | humanizeDuration }}</td>
<td>{{ node.detail['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ node.detail['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td nzRight [class.selected]="selectedNode?.id === node.id">
<flink-task-badge [tasks]="node.detail?.tasks"></flink-task-badge>
</td>
Expand Down
8 changes: 4 additions & 4 deletions ...dashboard/src/app/pages/job/overview/subtasks/job-overview-drawer-subtasks.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@
</td>
<td>{{ subtask.attempt + 1 }}</td>
<td>{{ subtask.host }}</td>
<td>{{ subtask['start_time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ subtask['start_time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ subtask.duration | humanizeDuration }}</td>
<td>{{ subtask['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ subtask['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>
{{ subtask['metrics']['accumulated-backpressured-time'] | humanizeDuration }}
/
Expand Down Expand Up @@ -165,9 +165,9 @@
</td>
<td>{{ attempt.attempt + 1 }}</td>
<td>{{ attempt.host }}</td>
<td>{{ attempt['start_time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ attempt['start_time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ attempt.duration | humanizeDuration }}</td>
<td>{{ attempt['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ attempt['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>
{{ attempt['metrics']['accumulated-backpressured-time'] | humanizeDuration }}
/
Expand Down
4 changes: 2 additions & 2 deletions ...d/src/app/pages/job/overview/taskmanagers/job-overview-drawer-taskmanagers.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
{{ taskManager['metrics']['write-records'] | number }}
</span>
</td>
<td>{{ taskManager['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ taskManager['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ taskManager['start-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ taskManager['end-time'] | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ taskManager['duration'] | humanizeDuration }}</td>
<td>
<flink-dynamic-host
Expand Down
4 changes: 2 additions & 2 deletions flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class JobTimelineComponent implements AfterViewInit, OnDestroy {
range: {
alias: 'Time',
type: 'time',
mask: 'HH:mm:ss',
mask: 'HH:mm:ss.SSS',
nice: false
}
});
Expand Down Expand Up @@ -155,7 +155,7 @@ export class JobTimelineComponent implements AfterViewInit, OnDestroy {
range: {
alias: 'Time',
type: 'time',
mask: 'HH:mm:ss',
mask: 'HH:mm:ss.SSS',
nice: false
}
});
Expand Down
2 changes: 1 addition & 1 deletion ...eb/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
{{ narrowData.name }}
</a>
</td>
<td>{{ narrowData.mtime | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
<td>{{ narrowData.mtime | humanizeDate: 'yyyy-MM-dd HH:mm:ss.SSS' }}</td>
<td>{{ narrowData.size / 1024 | number: '1.0-2' }}</td>
</tr>
</ng-container>
Expand Down