[hotfix] Short circuit judgment for create blob storage dir #26338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to short circuit judgment for create blob storage dir
According to
flink/flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/WorkingDirectory.java
Line 49 in df05858
, there are already existing the blob storage dir.
The original judgment executes
baseDir.mkdirs()
first, but it returns false. And then we need to executebaseDir.exists()
.We can only need execute
baseDir.exists()
first and short circuit judgment forbaseDir.mkdirs()
.According to the current code path, I think this is the mainly logic.
And this PR will not lead to any regression even if there exists some corner case.
Brief change log
Short circuit judgment for create blob storage dir
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation